Conversation
…age, updated C Port to match updates to dds-rtps
… prefix to regex, fixed code not finding the name for cyclonedds topics
Adde timeout to the samples_sent queue since a sufficiently fast dds's subscriber would return a sample to pexpect before the queue receives a sample from dds's publisher leading to an empty queue issue where it isn't supposed to happen
…QoS to function properly fixing Test_Durability_17
There was a problem hiding this comment.
I've done a quick review and I've added my feedback.
Also, this will require to modify the consideration per product: https://github.com/omg-dds/dds-rtps/blob/master/doc/test_description.template.rst?plain=1#L49 For example the usage of dds_take_next instead of take_next_instance and other considerations.
Additionally, you need to add cyclone on https://github.com/omg-dds/dds-rtps/blob/master/.github/workflows/1_run_interoperability_tests.yml
The branch add_new_test_python_0725 should contain fixes for the r on the python regex as well as a reimplementation of the test test_reliability_no_losses
Finally, in case a feature is not supported, it should print feature X: not supported for example:
https://github.com/omg-dds/dds-rtps/blob/master/srcCxx/shape_main.cxx#L1319 , that way, the script will report correctly if a feature is not supported.
Implemented the array of previous_instances Swapped the take_next function to the take_next_instance function Moved Return Loan to a more reasonable location dds_take(_next_instance) returns 0(DDS_RETCODE_OK) instead of DDS_RETCODE_NO_DATA which made the loop never exit, it should be fixed now
Also added j > 0 check
angelrti
left a comment
angelrti
left a comment
There was a problem hiding this comment.
Just a small typo, other than that it looks correct to me
|
@disganaitis we need to modify the yml script that runs the automation (depending on the executable name): https://github.com/omg-dds/dds-rtps/blob/master/.github/workflows/1_run_interoperability_tests.yml |
|
@disganaitis when merging the PR, please do 'Squash and merge'. Thanks |
|
@angelrti I don't seem to have the option to merge the branch |
|
I see, then I'll merge it for you |
|
Thank you! |
2 participants
Implemented CycloneDDS implementation of the dds-rtps test suite
Proposing adding the r prefix to every python regex as per the recommendation in the documentation
Race condition fix for test_reliability_no_losses
Added CLA for Rocket Software